Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
/ lanai Public archive

8247772: Lanai: Several jtreg tests fails with assertion validateText… #59

Closed
wants to merge 1 commit into from
Closed

8247772: Lanai: Several jtreg tests fails with assertion validateText… #59

wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Collaborator

@prsadhuk prsadhuk commented Jun 17, 2020 •
edited by openjdk bot

…ureDimensions: 759: failed assertion 'MTLTextureDescriptor has width greater than maximum allowed size of 16384'

Check texture width against MaxTextureSize of 16384 before using during MTL texture creation

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8247772: Lanai: Several jtreg tests fails with assertion validateTextureDimensions: 759: failed assertion 'MTLTextureDescriptor has width greater than maximum allowed size of 16384' ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/lanai pull/59/head:pull/59
$ git checkout pull/59

@prsadhuk
8247772: Lanai: Several jtreg tests fails with assertion validateText…
e673219 
…ureDimensions: 759: failed assertion 'MTLTextureDescriptor has width greater than maximum allowed size of 16384'
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@prsadhuk This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8247772: Lanai: Several jtreg tests fails with assertion validateText…
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate e16e7f0b61e37693641aeeca76888db188df4842.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2020
@prsadhuk
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jun 17, 2020
@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@prsadhuk
Pushed as commit 2947a7c.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 17, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2020

Mailing list message from Ajit Ghaisas on lanai-dev:

Hi Prasanta,

I have few review comments that I have captured in JDK-8247831 <https://bugs.openjdk.java.net/browse/JDK-8247831>

Regards,
Ajit

@prsadhuk prsadhuk deleted the assertion-fix branch July 17, 2020 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
1 participant
@prsadhuk